> From: [email protected] [mailto:netdev- > [email protected]] On Behalf Of Christophe JAILLET > Sent: Tuesday, February 6, 2018 11:48 AM > To: Kirsher, Jeffrey T <[email protected]> > Cc: [email protected]; [email protected]; linux- > [email protected]; [email protected]; Christophe > JAILLET <[email protected]> > Subject: [PATCH] igb: Fix a test with HWTSTAMP_TX_ON > > 'HWTSTAMP_TX_ON' should be handled as a value, not as a bit mask. > The modified code should behave the same, because HWTSTAMP_TX_ON is > 1 > and no other possible values of 'tx_type' would match the test. > However, this is more future-proof, should other values be allowed one day. > > See 'struct hwtstamp_config' in 'include/uapi/linux/net_tstamp.h' > > This fixes a warning reported by smatch: > igb_xmit_frame_ring() warn: bit shifter 'HWTSTAMP_TX_ON' used for > logical '&' > > Fixes: 26bd4e2db06be ("igb: protect TX timestamping from API misuse") > Signed-off-by: Christophe JAILLET <[email protected]> > --- > drivers/net/ethernet/intel/igb/igb_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >
Tested-by: Aaron Brown <[email protected]>
