On 02/14/2018 06:14 PM, Srinivas Kandagatla wrote:
>
>
> On 14/02/18 16:00, Stanimir Varbanov wrote:
>>> .../devicetree/bindings/pci/qcom,pcie.txt | 4 ++++
>>> drivers/pci/dwc/pcie-qcom.c | 24
>>> ++++++++++++++++++++--
>>> 2 files changed, 26 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.txt
>>> b/Documentation/devicetree/bindings/pci/qcom,pcie.txt
>>> index 3c9d321b3d3b..1fd703bd73e0 100644
>>> --- a/Documentation/devicetree/bindings/pci/qcom,pcie.txt
>>> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.txt
>>> @@ -189,6 +189,10 @@
>>> Value type: <phandle>
>>> Definition: A phandle to the analog power supply for IC which
>>> generates
>>> reference clock
>>> +- vddpe-3v3-supply:
>> shouldn't it be vddpe_3v3-supply to be aligned with the other supplies?
>>
> I noticed that, I had to do it intentionally
> As dt properties should follow - instead of _
I don't agree with that. If the supply name is more than one word it
should be separated by underscore ('git grep \-supply' in dts files).
--
regards,
Stan
