On 15/02/18 13:59, Lukas Senger wrote:

^^^^^^^^^^^^^^^^^^^
Missing description and signatures...

---
  drivers/pps/clients/pps-gpio.c | 1 +
  include/linux/pps-gpio.h       | 2 ++
  2 files changed, 3 insertions(+)

diff --git a/drivers/pps/clients/pps-gpio.c b/drivers/pps/clients/pps-gpio.c
index dd7624f1d23f..35c3b14fc9b9 100644
--- a/drivers/pps/clients/pps-gpio.c
+++ b/drivers/pps/clients/pps-gpio.c
@@ -196,6 +196,7 @@ static int pps_gpio_probe(struct platform_device *pdev)
        data->info.owner = THIS_MODULE;
        snprintf(data->info.name, PPS_MAX_NAME_LEN - 1, "%s.%d",
                 pdev->name, pdev->id);
+       data->info.echo = pps_gpio_echo;
/* register PPS source */
        pps_default_params = PPS_CAPTUREASSERT | PPS_OFFSETASSERT;
diff --git a/include/linux/pps-gpio.h b/include/linux/pps-gpio.h
index 0035abe41b9a..67f50e8dcd11 100644
--- a/include/linux/pps-gpio.h
+++ b/include/linux/pps-gpio.h
@@ -29,4 +29,6 @@ struct pps_gpio_platform_data {
        const char *gpio_label;
  };
+static void pps_gpio_echo(struct pps_device *pps, int event, void *data){}
+
  #endif

Why a void function? You should use it to toggle echoing GPIO... =8-o

Ciao,

Rodolfo

--

HCE Engineering                      e-mail: giome...@hce-engineering.it
GNU/Linux Solutions                          giome...@enneenne.com
Linux Device Driver                          giome...@linux.it
Embedded Systems                     phone:  +39 349 2432127
UNIX programming                     skype:  rodolfo.giometti
Cosino Project - the quick prototyping embedded system - www.cosino.it
Freelance ICT Italia - Consulente ICT Italia - www.consulenti-ict.it

Reply via email to