On Fri, Feb 16, 2018 at 11:45:51PM +0200, Andy Shevchenko wrote: > Now, the question about test case. Why do you heavily use BUG_ON? > Isn't resulting statistics enough?
No. If any of those tests fail, we want to stop dead. They'll lead to horrendous bugs throughout the kernel if they're wrong. I think more of the in-kernel test suite should stop dead instead of printing a warning. Would you want to boot a machine which has a known bug in the page cache, for example?
