2018-02-21 0:25 GMT+09:00 Richard Weinberger <rich...@nod.at>: > Am Dienstag, 20. Februar 2018, 16:18:11 CET schrieb Masahiro Yamada: >> 2018-02-19 18:22 GMT+09:00 Richard Weinberger <rich...@nod.at>: >> > Don't source the kernel config file in shell scripts. >> > The config file is not a shell script and often imported from untrusted >> > sources. >> > What could possible go wrong? ;-) >> >> Please enumerate your real problems. > > Build a kernel where the .config contains something like: > CONFIG_CMDLINE_BOOL=y > CONFIG_CMDLINE="`echo hello > world`"
Same for Makefile if a string symbol is referenced from Makefile, like CONFIG_CROSS_COMPILE="$(shell echo hello > world)aarch64-linux-gnu-" > I'll send a v3 because I forgot to convert one function in the shell script to > the new bash array. kbuild bot FTW. :-) You do not need to do so. This patch is so ugly. Also, changed shell scripts have '#!/bin/sh' shebang, but you are adding bash as a requirement. -- Best Regards Masahiro Yamada
