The RTC core is always calling rtc_valid_tm after the read_time callback.
It is not necessary to call it just before returning from the callback.

Signed-off-by: Alexandre Belloni <alexandre.bell...@bootlin.com>
---
 drivers/rtc/rtc-efi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/rtc/rtc-efi.c b/drivers/rtc/rtc-efi.c
index 0130afd7fe88..3454e7814524 100644
--- a/drivers/rtc/rtc-efi.c
+++ b/drivers/rtc/rtc-efi.c
@@ -176,7 +176,7 @@ static int efi_read_time(struct device *dev, struct 
rtc_time *tm)
        if (!convert_from_efi_time(&eft, tm))
                return -EIO;
 
-       return rtc_valid_tm(tm);
+       return 0;
 }
 
 static int efi_set_time(struct device *dev, struct rtc_time *tm)
-- 
2.16.1

Reply via email to