On Mon, Feb 26, 2018 at 12:54 AM, Robert Abel <ra...@robertabel.eu> wrote:
> Signed-off-by: Robert Abel <ra...@robertabel.eu>
> ---
> drivers/auxdisplay/charlcd.c | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/auxdisplay/charlcd.c b/drivers/auxdisplay/charlcd.c
> index e3b2fd15c5a3..a3d364e6c666 100644
> --- a/drivers/auxdisplay/charlcd.c
> +++ b/drivers/auxdisplay/charlcd.c
> @@ -67,6 +67,11 @@
> #define LCD_ESCAPE_LEN 24 /* Max chars for LCD escape command */
> #define LCD_ESCAPE_CHAR 27 /* Use char 27 for escape
> command */
>
> +struct charlcd_priv_addr {
> + unsigned long int x;
> + unsigned long int y;
> +};
> +
> struct charlcd_priv {
> struct charlcd lcd;
>
> @@ -80,12 +85,9 @@ struct charlcd_priv {
> unsigned long int flags;
>
> /* Contains the LCD X and Y offset */
> - struct {
> - unsigned long int x;
> - unsigned long int y;
> - } addr;
> + struct charlcd_priv_addr addr;
Since this is a very small change and you use it in the 3rd patch, I
think it is clearer to have it there.
>
> - /* Current escape sequence and it's length or -1 if outside */
> + /* Current escape sequence and its length or -1 if outside */
While this could be left in its own patch ("fix typo...").
Thanks!
Miguel
> struct {
> char buf[LCD_ESCAPE_LEN + 1];
> int len;
> --
> 2.11.0
>
