Hi Andy, Hi Miguel, On 26 Feb 2018 12:44, Andy Shevchenko wrote: > Can we avoid yoda style of programming? On 26 Feb 2018 17:49, Miguel Ojeda wrote: > Please do not change the style of the code w.r.t to the rest of the > file, which writes tests with the non-lvalue on the right-hand side > and do not compare against '\0'. Same for the rest.
I am actually a fan of yoda-style programming, although its value is diminished with modern IDEs, which we all use, right? On 26 Feb 2018 17:54, Miguel Ojeda wrote: > On Mon, Feb 26, 2018 at 12:44 PM, Andy Shevchenko >> Perhaps instead of dancing around kstrtox() better to switch to >> simple_strtoul() ? > > It seems deprecated: > > /* Obsolete, do not use. Use kstrto<foo> instead */ > extern unsigned long simple_strtoul(const char *,char **,unsigned int); I thought the whole point was that simple_strtoul is deprecated and on the kill list? Isn't that kind of against the whole argument of re-inventing the wheel? If using simple_strtoul is an option, it might be best to bring it back and not touch the buffer at all. Regards, Robert
