> -----Original Message----- > From: Borislav Petkov [mailto:b...@suse.de] > Sent: Tuesday, February 27, 2018 9:30 AM > To: Ghannam, Yazen <yazen.ghan...@amd.com> > Cc: linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; > ard.biesheu...@linaro.org; x...@kernel.org > Subject: Re: [PATCH v2 4/8] efi: Decode UEFI-defined IA32/X64 Error > Structure GUIDs > > On Mon, Feb 26, 2018 at 01:39:00PM -0600, Yazen Ghannam wrote: > > @@ -45,6 +81,11 @@ void cper_print_proc_ia(const char *pfx, const struct > cper_sec_proc_ia *proc) > > printk("%sError Structure Type: %pUl\n", newpfx, > > &err_info->err_type); > > > > + err_type = cper_get_err_type(&err_info->err_type); > > + printk("%sError Structure Type: %s\n", newpfx, > > + err_type < ARRAY_SIZE(cper_proc_error_type_strs) ? > > + cper_proc_error_type_strs[err_type] : "unknown"); > > Ah, there it is, much better. Now this tells us what component it is. > > So cper-arm.c does the same thing and there's a similar thing in cper.c - > cper_print_proc_generic(). > > Let's not tri-plicate that code pls and have a generic function instead. >
Sure, I can do that. Ard, is this okay? Thanks, Yazen
