On Tue, Feb 27, 2018 at 12:07 PM, Sebastian Panceac <[email protected]> wrote: > Hi Andy,
Thanks for an update! My comments below. > I fixed the commit description according to your suggestions and used git > send-email. > > Regards! Changelog, which is effectively above paragraph, should go after --- line below. Version of the patch should be increased (this one is v2 so far). You should include all maintainers and designated reviewers of the code in question. get_maintainer.pl script (in scripts/) will help you. So, please resend taking into consideration all above. > When powering Intel Edison module with 3.3V, > the "reboot" command makes the module stuck. > If the module is powered at a greater voltage, > like 4.4V(as the Edison Mini Breakout board does), reboot works OK. This looks a bit shorter than we have room for. I mean, 72 characters per line is pretty much OK. Also, don't miss a space before (. > This patch copies the behaviour from the official Intel Edison BSP, > where "IPCMSG_COLD_RESET" message > was sent to SCU by default at reboot time. > > In the official BSP, sending the "IPCMSG_COLD_BOOT" message instead > of "IPCMSG_COLD_RESET" was possible, > by using a kernel command line parameter. > > Signed-off-by: Sebastian Panceac <[email protected]> > --- ...changelog goes here... > arch/x86/platform/intel-mid/intel-mid.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) -- With Best Regards, Andy Shevchenko
