Hi Moritz

> - Consistency for NIXGE_MDIO_CXX_READ constants

> +#define NIXGE_MDIO_CLAUSE45  BIT(12)
> +#define NIXGE_MDIO_CLAUSE22  0
> +#define NIXGE_MDIO_OP(n)     (((n) & 0x3) << 10)
> +#define NIXGE_MDIO_OP_ADDRESS        0
> +#define NIXGE_MDIO_OP_WRITE  BIT(0)
> +#define NIXGE_MDIO_C45_READ  (BIT(1) | BIT(0))
> +#define NIXGE_MDIO_C22_WRITE BIT(0)
> +#define NIXGE_MDIO_C22_READ  BIT(1)

Thanks for making READ consistent. But what about WRITE?  I'd suggest
you don't just blindly follow comments, but think about them.

    Andrew

Reply via email to