> -----Original Message----- > From: rjwyso...@gmail.com [mailto:rjwyso...@gmail.com] On Behalf Of Rafael J. > Wysocki > Sent: Friday, March 2, 2018 3:43 AM > To: Limonciello, Mario <mario_limoncie...@dell.com> > Cc: Andy Shevchenko <andy.shevche...@gmail.com>; Rafael J. Wysocki > <r...@rjwysocki.net>; ACPI Devel Maling List <linux-a...@vger.kernel.org>; > Linux > Kernel Mailing List <linux-kernel@vger.kernel.org> > Subject: Re: [RFC] power/hibernate: Make passing hibernate offsets more > friendly > > On Wed, Feb 28, 2018 at 9:05 PM, <mario.limoncie...@dell.com> wrote: > > > > > >> -----Original Message----- > >> From: Andy Shevchenko [mailto:andy.shevche...@gmail.com] > >> Sent: Wednesday, February 28, 2018 12:11 PM > >> To: Limonciello, Mario <mario_limoncie...@dell.com> > >> Cc: Rafael J . Wysocki <r...@rjwysocki.net>; ACPI Devel Maling List <linux- > >> a...@vger.kernel.org>; LKML <linux-kernel@vger.kernel.org> > >> Subject: Re: [RFC] power/hibernate: Make passing hibernate offsets more > >> friendly > >> > >> On Wed, Feb 28, 2018 at 7:43 PM, Mario Limonciello > >> <mario.limoncie...@dell.com> wrote: > >> > Currently the only way to specify a hibernate offset for a swap > >> > file is on the kernel command line. > >> > > >> > This makes some changes to improve: > >> > 1) Add a new /sys/power/disk_offset that lets userspace specify > >> > the offset and disk to use when initiating a hibernate cycle. > >> > > >> > 2) Adjust /sys/power/resume interpretation to also read in an > >> > offset. > >> > >> Read is okay per se (not consistent though), showing is not. > >> It might break an ABI. > > > > Right this is part of why I was proposing making a new attribute. > > > > The current RFC implementation I sent keeps the read output the > > same for /sys/power/resume. > > You also need to retain the write behavior of it. > > A new attribute is fine if it helps, but the behavior of the existing > one cannot change (both sides).
Thanks for your feedback, I'll adjust it as such.
