On Thu, Mar 1, 2018 at 12:39 AM, Sebastian Andrzej Siewior <bige...@linutronix.de> wrote: > On 2018-02-28 19:27:54 [-0800], Derek Basehore wrote: >> If cpu_cluster_pm_enter() fails, cpu_pm_exit() should be called. This >> will put the CPU in the correct state to resume from the failure. > > Was this triggered or found on review? Either way it was introduced in > 6f3eaec87b6b ("cpu_pm: call notifiers during suspend") > and I might need a stable tag.
It was found during review. I was able to verify that this is a bug, though. The Rockchip RK3399 doesn't use cluster idle except during suspend. If I just return an error for cpu_cluster_pm_enter, the machine wedges. Including this patch makes it error out of suspend gracefully. > >> Signed-off-by: Derek Basehore <dbaseh...@chromium.org> > > Sebastian