In file included from ./include/linux/acpi.h:28:0,
from ./include/linux/ipmi.h:21,
from drivers/char/ipmi/ipmi_dmi.c:7:
drivers/char/ipmi/ipmi_dmi.c: In function ‘dmi_add_platform_ipmi’:
./include/linux/property.h:236:1: error: expected expression before
‘{’ token
{ \
^
./include/linux/property.h:244:2: note: in expansion of macro
‘PROPERTY_ENTRY_INTEGER’
PROPERTY_ENTRY_INTEGER(_name_, u8, _val_)
^~~~~~~~~~~~~~~~~~~~~~
drivers/char/ipmi/ipmi_dmi.c:79:15: note: in expansion of macro
‘PROPERTY_ENTRY_U8’
p[pidx++] = PROPERTY_ENTRY_U8("ipmi-type", si_type);
^~~~~~~~~~~~~~~~~
./include/linux/property.h:236:1: error: expected expression before
‘{’ token
{ \
^
./include/linux/property.h:244:2: note: in expansion of macro
‘PROPERTY_ENTRY_INTEGER’
PROPERTY_ENTRY_INTEGER(_name_, u8, _val_)
^~~~~~~~~~~~~~~~~~~~~~
drivers/char/ipmi/ipmi_dmi.c:81:14: note: in expansion of macro
‘PROPERTY_ENTRY_U8’
p[pidx++] = PROPERTY_ENTRY_U8("slave-addr", slave_addr);
^~~~~~~~~~~~~~~~~
./include/linux/property.h:236:1: error: expected expression before
‘{’ token
{ \
^
./include/linux/property.h:244:2: note: in expansion of macro
‘PROPERTY_ENTRY_INTEGER’
PROPERTY_ENTRY_INTEGER(_name_, u8, _val_)
^~~~~~~~~~~~~~~~~~~~~~
drivers/char/ipmi/ipmi_dmi.c:82:14: note: in expansion of macro
‘PROPERTY_ENTRY_U8’
p[pidx++] = PROPERTY_ENTRY_U8("addr-source", SI_SMBIOS);
^~~~~~~~~~~~~~~~~
./include/linux/property.h:236:1: error: expected expression before
‘{’ token
{ \
^
./include/linux/property.h:246:2: note: in expansion of macro
‘PROPERTY_ENTRY_INTEGER’
PROPERTY_ENTRY_INTEGER(_name_, u16, _val_)
^~~~~~~~~~~~~~~~~~~~~~
drivers/char/ipmi/ipmi_dmi.c:107:15: note: in expansion of macro
‘PROPERTY_ENTRY_U16’
p[pidx++] = PROPERTY_ENTRY_U16("i2c-addr", base_addr);
^~~~~~~~~~~~~~~~~~
I don't think that macro is actually a replacement?
Thanks,
Laura
BTW, the IPMI setup in your system is incorrect. SMBIOS says it's
at a
memory address, but it's at an I/O address. And the address given
doesn't appear to be a valid address, the value read doesn't appear
to be a valid value.
-corey
for that fix.
-corey
Yeah, this is fixed by 174134ac7602 "ipmi_si: Fix error
handling of platform device" in mainstream.
I guess I need to request a backport of this.
Thanks for reporting.
-corey
Thanks,
Laura