On Wednesday 07 March 2018 12:10 PM, Avri Altman wrote: > >> -----Original Message----- >> From: Harish Jenny K N [mailto:[email protected]] >> Sent: Wednesday, March 07, 2018 7:38 AM >> To: [email protected]; [email protected]; >> [email protected]; [email protected]; Avri Altman >> <[email protected]>; [email protected] >> Cc: [email protected]; [email protected]; >> [email protected]; [email protected] >> Subject: [PATCH v6] mmc: Export host capabilities to debugfs. >> >> This patch exports the host capabilities to debugfs >> >> This idea of sharing host capabilities over debugfs came up from Abbas Raza >> <[email protected]> Earlier discussions: >> https://lkml.org/lkml/2018/3/5/357 >> https://www.spinics.net/lists/linux-mmc/msg48219.html >> >> Signed-off-by: Harish Jenny K N <[email protected]> >> --- >> >> >> +static int mmc_caps_show(struct seq_file *s, void *unused) { >> + struct mmc_host *host = s->private; >> + u32 caps = host->caps; >> + >> + seq_puts(s, "\nMMC Host capabilities are:\n"); >> + seq_puts(s, >> "=============================================\n"); >> + seq_printf(s, "Can the host do 4 bit transfers :\t%s\n", >> + ((caps & MMC_CAP_4_BIT_DATA) ? "Yes" : "No")); > Maybe use a more compact form, and just call a macro with the applicable > (stringified) bit?
Something like this ? #define YN(bit) ((caps & bit) ? "Yes" : "No") and then call seq_printf(s, "Can the host do 4 bit transfers :\t%s\n", YN(MMC_CAP_4_BIT_DATA)); Thanks, Harish Jenny K N
