On 03/07/2018 12:35 PM, Ganapatrao Kulkarni wrote: > Hi Will Cohen, > > On Wed, Mar 7, 2018 at 8:08 PM, Arnaldo Carvalho de Melo > <a...@kernel.org> wrote: >> Em Wed, Mar 07, 2018 at 09:32:05AM -0500, William Cohen escreveu: >>> On 03/07/2018 06:08 AM, Ganapatrao Kulkarni wrote: >>>> There is MIDR change on ThunderX2 B0, adding an entry to mapfile >>>> to enable JSON events for B0. >>>> >>>> Signed-off-by: Ganapatrao Kulkarni <ganapatrao.kulka...@cavium.com> >> >> Ganapatrao, can you please take this in consideration and if agreeing >> send a v2 patch? >> >> With that I can add an Acked-by: wcohen, Right? >> >> - Arnaldo >>>> --- >>>> tools/perf/pmu-events/arch/arm64/mapfile.csv | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/tools/perf/pmu-events/arch/arm64/mapfile.csv >>>> b/tools/perf/pmu-events/arch/arm64/mapfile.csv >>>> index e61c9ca..93c5d14 100644 >>>> --- a/tools/perf/pmu-events/arch/arm64/mapfile.csv >>>> +++ b/tools/perf/pmu-events/arch/arm64/mapfile.csv >>>> @@ -13,4 +13,5 @@ >>>> # >>>> #Family-model,Version,Filename,EventType >>>> 0x00000000420f5160,v1,cavium,core >>>> +0x00000000430f0af0,v1,cavium,core >>>> 0x00000000410fd03[[:xdigit:]],v1,cortex-a53,core >>>> >>> >>> Hi, >>> Like the cortex-a53 the last digit '0' of the match for the MIDR should be >>> replaced with [[:xdigit:]] to allow for possible future revisions of chip: > > for arm64 implementation, bits 3:0(Revision) and bits 23:20(Variant) > are ignored/dont-care.
Thanks for pointing that out. See the code masking out those bits in linux/toos/perf/arch/util/header.c. For the ppc64 it just copies the equivalent of the MIDR including the revision bits. Thus, the need for regular expression matching to avoid having to create a new entry for each revision. -Will > >>> >>> 0x00000000430f0af[[:xdigit:]],v1,cavium,core >>> >>> >>> -Will Cohen >> > > thanks > Ganapat >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-ker...@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
