3.2.101-rc1 review patch.  If anyone has any objections, please let me know.

------------------

From: Danny Kukawka <danny.kuka...@bisect.de>

commit 32d7e63c1f4f86ad18404e3f36be99c9910fae9b upstream.

Fix for some -Wuninitialized compiler warnings.

Signed-off-by: Danny Kukawka <danny.kuka...@bisect.de>
Signed-off-by: Mauro Carvalho Chehab <mche...@redhat.com>
Signed-off-by: Ben Hutchings <b...@decadent.org.uk>
---
 drivers/media/common/tuners/max2165.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

--- a/drivers/media/common/tuners/max2165.c
+++ b/drivers/media/common/tuners/max2165.c
@@ -168,7 +168,7 @@ int fixpt_div32(u32 dividend, u32 diviso
        int i;
 
        if (0 == divisor)
-               return -1;
+               return -EINVAL;
 
        q = dividend / divisor;
        remainder = dividend - q * divisor;
@@ -194,10 +194,13 @@ static int max2165_set_rf(struct max2165
        u8 tf_ntch;
        u32 t;
        u32 quotient, fraction;
+       int ret;
 
        /* Set PLL divider according to RF frequency */
-       fixpt_div32(freq / 1000, priv->config->osc_clk * 1000,
-               &quotient, &fraction);
+       ret = fixpt_div32(freq / 1000, priv->config->osc_clk * 1000,
+                        &quotient, &fraction);
+       if (ret != 0)
+               return ret;
 
        /* 20-bit fraction */
        fraction >>= 12;

Reply via email to