* kan.li...@linux.intel.com <kan.li...@linux.intel.com> wrote:

> +     /*TODO: test Adaptive PEBS, no extra implementation needed */
> +             /*TODO: test PDIR fixed counter */
> +             /* TODO: OFFCORE_RESPONSE mask updates for 10nm convered IDI */
> +             /*TODO: implement topdown metrics, base metrics interface same 
> as SNC */

Do you ever _read_ the comments you are writing?

NAK for this kind of inconsistent mess, and it's a repeat pattern - you really 
need to submit cleaner patches!

Thanks,

        Ingo

Reply via email to