On 03/12/2018 04:59 PM, Marc Zyngier wrote: > On 12/03/18 08:06, Rajendra Nayak wrote: >> Add a skeletal sdm845 SoC dtsi and MTP board dts/dtsi files >> >> Signed-off-by: Rajendra Nayak <[email protected]> >> Reviewed-by: Doug Anderson <[email protected]> >> --- >> arch/arm64/boot/dts/qcom/Makefile | 1 + >> arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 15 ++ >> arch/arm64/boot/dts/qcom/sdm845.dtsi | 278 >> ++++++++++++++++++++++++++++++++ >> 3 files changed, 294 insertions(+) >> create mode 100644 arch/arm64/boot/dts/qcom/sdm845-mtp.dts >> create mode 100644 arch/arm64/boot/dts/qcom/sdm845.dtsi >> >> diff --git a/arch/arm64/boot/dts/qcom/Makefile >> b/arch/arm64/boot/dts/qcom/Makefile >> index 55ec5ee7f7e8..9319e74b8906 100644 >> --- a/arch/arm64/boot/dts/qcom/Makefile >> +++ b/arch/arm64/boot/dts/qcom/Makefile >> @@ -6,3 +6,4 @@ dtb-$(CONFIG_ARCH_QCOM) += msm8916-mtp.dtb >> dtb-$(CONFIG_ARCH_QCOM) += msm8992-bullhead-rev-101.dtb >> dtb-$(CONFIG_ARCH_QCOM) += msm8994-angler-rev-101.dtb >> dtb-$(CONFIG_ARCH_QCOM) += msm8996-mtp.dtb >> +dtb-$(CONFIG_ARCH_QCOM) += sdm845-mtp.dtb >> diff --git a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts >> b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts >> new file mode 100644 >> index 000000000000..979ab49913f1 >> --- /dev/null >> +++ b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts >> @@ -0,0 +1,15 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/* >> + * SDM845 MTP board device tree source >> + * >> + * Copyright (c) 2018, The Linux Foundation. All rights reserved. >> + */ >> + >> +/dts-v1/; >> + >> +#include "sdm845.dtsi" >> + >> +/ { >> + model = "Qualcomm Technologies, Inc. SDM845 MTP"; >> + compatible = "qcom,sdm845-mtp"; >> +}; >> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi >> b/arch/arm64/boot/dts/qcom/sdm845.dtsi >> new file mode 100644 >> index 000000000000..d2407cd7a561 >> --- /dev/null >> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi > > [...] > >> + intc: interrupt-controller@17a00000 { >> + compatible = "arm,gic-v3"; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + ranges; >> + #interrupt-cells = <3>; >> + interrupt-controller; >> + #redistributor-regions = <1>; >> + redistributor-stride = <0x0 0x20000>; > > You shouldn't need redistributor-stride here, unless your GIC > implementation is not compliant with the architecture (i.e. really > buggy). I only know of one such implementation, and I'd rather you > remove this property unless your GIC is indeed non-compliant. If that's > the case, you should also document it.
Thanks Marc, I will drop the redistributor-stride and #redistributor-regions as the bindings document seems to suggest its optional and is needed only when more than 1 such region is present. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
