On Tue, Mar 13, 2018 at 8:54 PM, Gary R Hook <gary.h...@amd.com> wrote: > On 03/13/2018 12:20 PM, Andy Shevchenko wrote:
>>> + } else if (obuf[0] == '0' && obuf[1] == 'x') { >>> + n = sscanf(obuf, "%x", &amd_iommu_devid); >>> + } else { >>> + n = sscanf(obuf, "%d", &amd_iommu_devid); >>> + } >> kstrtoint() ? > I see various mechanisms for this sort of thing, and simply chose one. > Am happy to use whatever is preferred. sscanf() has an enormous overhead for cases like this. simple ret = kstrtoint(); if (ret) ... do error handling ... -- With Best Regards, Andy Shevchenko