Hi Thierry,

> Add binding document for serial bluetooth chips using Qualcomm protocol.
> 
> Signed-off-by: Thierry Escande <thierry.esca...@linaro.org>
> ---
> 
> v4:
> - Move bt-disable-n-gpios to required properties section
> - Add clocks and pinctrl-0 as required properties
> 
> v3: no change
> v2: no change
> 
> .../devicetree/bindings/net/qualcomm-bluetooth.txt | 34 ++++++++++++++++++++++
> 1 file changed, 34 insertions(+)
> create mode 100644 
> Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
> 
> diff --git a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt 
> b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
> new file mode 100644
> index 000000000000..cdb14b96c229
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
> @@ -0,0 +1,34 @@
> +Qualcomm Bluetooth Chips
> +---------------------
> +
> +This documents the binding structure and common properties for serial
> +attached Qualcomm devices.
> +
> +Serial attached Qualcomm devices shall be a child node of the host UART
> +device the slave device is attached to.
> +
> +Required properties:
> + - compatible: should contain one of the following:
> +   * "qcom,qca6174-bt"
> + - bt-disable-n-gpios: gpio specifier, used to enable chip during probe
> + - pinctrl-0: pin phandle for bt_en gpio
> + - clocks: clock phandle for SUSCLK_32KHZ
> +
> +Example:
> +
> +serial@7570000 {
> +     pinctrl-names = "default", "sleep";
> +     pinctrl-0 = <&blsp1_uart1_default>;
> +     pinctrl-1 = <&blsp1_uart1_sleep>;
> +
> +     bluetooth {
> +             compatible = "qcom,qca6174-bt";
> +
> +             bt-disable-n-gpios = <&pm8994_gpios 19 GPIO_ACTIVE_HIGH>;

can we use a common name here. I think that Nokia and Broadcom drivers define 
one. And if this is the enable/shutdown GPIO, we should name it consistently 
across all manufacturers. It essentially does the same on Bluetooth UART chips 
no matter what chip is behind them.

Regards

Marcel

Reply via email to