We can return directly at the beginning of the function and save the 'err'
label.
We can also explicitly return 0 when the probe succeed.

Signed-off-by: Christophe JAILLET <christophe.jail...@wanadoo.fr>
---
 drivers/remoteproc/imx_rproc.c | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
index 6d02ef62a626..54c07fd3f204 100644
--- a/drivers/remoteproc/imx_rproc.c
+++ b/drivers/remoteproc/imx_rproc.c
@@ -333,10 +333,8 @@ static int imx_rproc_probe(struct platform_device *pdev)
        /* set some other name then imx */
        rproc = rproc_alloc(dev, "imx-rproc", &imx_rproc_ops,
                            NULL, sizeof(*priv));
-       if (!rproc) {
-               ret = -ENOMEM;
-               goto err;
-       }
+       if (!rproc)
+               return -ENOMEM;
 
        dcfg = of_device_get_match_data(dev);
        if (!dcfg) {
@@ -381,13 +379,13 @@ static int imx_rproc_probe(struct platform_device *pdev)
                goto err_put_clk;
        }
 
-       return ret;
+       return 0;
 
 err_put_clk:
        clk_disable_unprepare(priv->clk);
 err_put_rproc:
        rproc_free(rproc);
-err:
+
        return ret;
 }
 
-- 
2.14.1

Reply via email to