On Thu, 15 Mar 2018 13:57:55 +0530
Ravi Bangoria <ravi.bango...@linux.vnet.ibm.com> wrote:
> tu->offset is unsigned long, not a pointer, thus %lx should
> be used to print it, not the %px.
>
This looks good to me.
Acked-by: Masami Hiramatsu <mhira...@kernel.org>
Thanks,
> Fixes: 0e4d819d0893 ("trace_uprobe: Display correct offset in uprobe_events")
> Suggested-by: Kees Cook <keesc...@chromium.org>
> Signed-off-by: Ravi Bangoria <ravi.bango...@linux.vnet.ibm.com>
> ---
> v2 changelog:
> - Keep prefixed 0s as is.
>
> kernel/trace/trace_uprobe.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
> index 2014f4351ae0..0298bd15be83 100644
> --- a/kernel/trace/trace_uprobe.c
> +++ b/kernel/trace/trace_uprobe.c
> @@ -608,7 +608,7 @@ static int probes_seq_show(struct seq_file *m, void *v)
>
> /* Don't print "0x (null)" when offset is 0 */
> if (tu->offset) {
> - seq_printf(m, "0x%px", (void *)tu->offset);
> + seq_printf(m, "0x%0*lx", (int)(sizeof(void *) * 2), tu->offset);
> } else {
> switch (sizeof(void *)) {
> case 4:
> --
> 2.13.6
>
--
Masami Hiramatsu <mhira...@kernel.org>
