On Thu, Mar 15, 2018 at 9:44 AM, Thomas Gleixner <t...@linutronix.de> wrote: > On Wed, 14 Mar 2018, Arnd Bergmann wrote: >> >> /* >> + * legacy timeval structure, only embedded in structures that >> + * traditionally used 'timeval' to pass time intervals (not absolute >> + * times). Do not add new users. If user space fails to compile >> + * here, this is probably because it is not y2038 safe and needs to >> + * be changed to use another interface. >> + */ >> +struct __kernel_old_timeval { >> + __kernel_long_t tv_sec; /* seconds */ >> + __kernel_long_t tv_usec; /* microseconds */ > > Please don't use these horrible tail comments. If you want to document the > obvious, then please use proper kernel doc.
I just removed them now, the only reason they were there is to keep the style in sync with the rest of the file, but it's also just a lot of duplication. Arnd