On Fri, Mar 16, 2018 at 01:54:23AM -0700, Christoph Hellwig wrote: > On Thu, Mar 15, 2018 at 05:54:27PM -0700, Linus Torvalds wrote: > > Yes. And honestly, I'd rather have these kinds of "just change the > > calling convention" almost automated patches separately - and then the > > cleanups later. > > > > Mixing the calling convention change and the cleanup together is just > > confusing and potentially causes subtle issues. > > A lot of the issues here is that the initramfs / do_mount code > is written as if it was user space code, but in kernel space. E.g. > using file desriptors etc.
... and I still wonder if it would make more sense to kick that crap out into userland.