4.15-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Dan Carpenter <[email protected]>


[ Upstream commit 7d54d0d38ec42559c891526f079f1e035cd4b3ae ]

The original code does this: "1 << (1 << 11)" which is undefined in C.

Fixes: dbc4deda03fe ("power: Adds support for Smart Battery System Manager")
Signed-off-by: Dan Carpenter <[email protected]>
Signed-off-by: Sebastian Reichel <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
---
 drivers/power/supply/sbs-manager.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/power/supply/sbs-manager.c
+++ b/drivers/power/supply/sbs-manager.c
@@ -183,7 +183,7 @@ static int sbsm_select(struct i2c_mux_co
                return ret;
 
        /* chan goes from 1 ... 4 */
-       reg = 1 << BIT(SBSM_SMB_BAT_OFFSET + chan);
+       reg = BIT(SBSM_SMB_BAT_OFFSET + chan);
        ret = sbsm_write_word(data->client, SBSM_CMD_BATSYSSTATE, reg);
        if (ret)
                dev_err(dev, "Failed to select channel %i\n", chan);


Reply via email to