[PATCH 4.9 52/86] Input: tca8418_keypad - remove double read of key event register

Fri, 16 Mar 2018 09:56:54 -0700 

4.9-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Dmitry Torokhov <[email protected]>

commit 9dd46c02532a6bed6240101ecf4bbc407f8c6adf upstream.

There is no need to tread the same register twice in a row.

Fixes: ea4348c8462a ("Input: tca8418_keypad - hide gcc-4.9 -Wmaybe-un ...")
Signed-off-by: Dmitry Torokhov <[email protected]>
Cc: Ben Hutchings <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

---
 drivers/input/keyboard/tca8418_keypad.c |    2 --
 1 file changed, 2 deletions(-)

--- a/drivers/input/keyboard/tca8418_keypad.c
+++ b/drivers/input/keyboard/tca8418_keypad.c
@@ -189,8 +189,6 @@ static void tca8418_read_keypad(struct t
                input_event(input, EV_MSC, MSC_SCAN, code);
                input_report_key(input, keymap[code], state);
 
-               /* Read for next loop */
-               error = tca8418_read_byte(keypad_data, REG_KEY_EVENT_A, &reg);
        } while (1);
 
        input_sync(input);

Reply via email to