Hi Dan, I love your patch! Yet something to improve:
[auto build test ERROR on linus/master] [also build test ERROR on v4.16-rc5] [cannot apply to next-20180316] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Dan-Williams/dax-fix-dma-vs-truncate-hole-punch/20180318-050250 config: x86_64-randconfig-s2-03180641 (attached as .config) compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All errors (new ones prefixed by >>): fs//xfs/xfs_file.c: In function 'xfs_break_dax_layouts': >> fs//xfs/xfs_file.c:786:8: error: implicit declaration of function >> '___wait_var_event' [-Werror=implicit-function-declaration] ret = ___wait_var_event(&page->_refcount, ^~~~~~~~~~~~~~~~~ fs//xfs/xfs_file.c:788:4: error: invalid use of void expression 0, 0, xfs_wait_var_event(inode, iolock)); ^ cc1: some warnings being treated as errors -- drivers//dax/super.c: In function 'generic_dax_pagefree': >> drivers//dax/super.c:170:2: error: implicit declaration of function >> 'wake_up_var' [-Werror=implicit-function-declaration] wake_up_var(&page->_refcount); ^~~~~~~~~~~ cc1: some warnings being treated as errors vim +/___wait_var_event +786 fs//xfs/xfs_file.c 773 774 static int 775 xfs_break_dax_layouts( 776 struct inode *inode, 777 uint iolock) 778 { 779 struct page *page; 780 int ret; 781 782 page = dax_layout_busy_page(inode->i_mapping); 783 if (!page) 784 return 0; 785 > 786 ret = ___wait_var_event(&page->_refcount, 787 atomic_read(&page->_refcount) == 1, TASK_INTERRUPTIBLE, 788 0, 0, xfs_wait_var_event(inode, iolock)); 789 if (ret < 0) 790 return ret; 791 return 1; 792 } 793 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
