On Sat, Mar 17, 2018 at 07:54:22PM +0000, Jonathan Cameron wrote: > On Wed, 14 Mar 2018 16:15:32 +0100 > SF Markus Elfring <elfr...@users.sourceforge.net> wrote: > > > From: Markus Elfring <elfr...@users.sourceforge.net> > > Date: Wed, 14 Mar 2018 16:06:49 +0100 > > > > * Add jump targets so that a call of the function "mutex_unlock" is stored > > only once in these function implementations. > > > > * Replace 19 calls by goto statements. > > > > This issue was detected by using the Coccinelle software. > > > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> > > Hi Markus, > > Some of these are good and sensible changes - others break the code. > Please be careful to fully check all the resulting paths and ensure > we don't change wether the lock is still held in all exit paths. > Note a function that isn't lockdep annotated should not be holding > any locks, that it took, upon exit.
Please note that you are dealing with someone who is on many kernel maintainer's email-blacklist, including my own. I've found it's just not worth the time and energy in responding to these emails, it's a time-sink you will never find your way out of. good luck! greg k-h
