* Arnaldo Carvalho de Melo ([EMAIL PROTECTED]) wrote: > The fix for the fix needed a fix: allocate_msrs() was using > for_each_online_cpu(), but nmi_setup uses for_each_possible_cpu(), and > in my test machine, a Dell Poweredge 1950 I have 2 dual core Xeons, > which makes for 4 possible cores, but wait, they are HT capable, so... > > [EMAIL PROTECTED] linux-2.6.21.3.orig]$ dmesg | grep Allowing > SMP: Allowing 8 CPUs, 4 hotplug CPUs > [EMAIL PROTECTED] linux-2.6.21.3.orig]$ > > We have 8 possible CPUs, but only 4 online, b00m. Fix it by making > allocate_msrs agree with nmi_setup, i.e. make both use > for_each_possible_cpu(). > > Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]>
Acked-by: Chris Wright <[EMAIL PROTECTED]> Thanks Arnaldo. I noticed this earlier, but mistakenly didn't consider it an issue aside of code needing to be cleaned up and for hotplug (which I thought was already broken for other reasons). And the Opteron I tested on has possible == online. I tested this addition on both the AMD box, as well as an Intel box with possible > online. All looks good. thanks, -chris - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
