On Thu, 31 May 2007, Antonino A. Daplas wrote:
> On Wed, 2007-05-30 at 22:04 +0400, Alexey Dobriyan wrote:
> > 2) palette in neofb_par is "u32 palette[16];" which is 4x16 = 64 bytes.
> > struct fb_info::pseudo_palette is assigned to it in neo_alloc_fb_info().
> > Yet, we check at the beginning of neofb_setcolreg() for color map
> > length which neofb advertises as 256 which seems too many.
> >
>
> Yes, 256 is too many. the pseudo_palette is used for the 16-color
> console only.
>
> I'm impressed that this bug has escaped notice for this long. That bug
> is present since the 2.5.x era.
>
> Probably, the best thing to do is hide the pseudo_palette from the
> drivers and move it to the console layer where it belongs to spare
> future driver writers from palette usage confusion. That will be a
> thankless job.
The console layer doesn't know how to fill in the pseudo palette in all
cases, that's why the driver have to do it.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [EMAIL PROTECTED]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
