Hi, Fabio Anson Huang Best Regards!
> -----Original Message----- > From: Fabio Estevam [mailto:[email protected]] > Sent: Sunday, March 18, 2018 9:04 PM > To: Anson Huang <[email protected]> > Cc: Shawn Guo <[email protected]>; Sascha Hauer > <[email protected]>; Fabio Estevam <[email protected]>; Rob > Herring <[email protected]>; Mark Rutland <[email protected]>; > Russell King - ARM Linux <[email protected]>; Michael Turquette > <[email protected]>; Stephen Boyd <[email protected]>; S.j. Wang > <[email protected]>; dl-linux-imx <[email protected]>; moderated > list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE > <[email protected]>; open list:OPEN FIRMWARE AND > FLATTENED DEVICE TREE BINDINGS <[email protected]>; linux-kernel > <[email protected]>; linux-clk <[email protected]> > Subject: Re: [PATCH 2/2] ARM: dts: imx6sx-sabreauto: add external 24MHz clock > source > > On Sun, Mar 18, 2018 at 12:14 AM, Anson Huang <[email protected]> > wrote: > > > diff --git a/arch/arm/boot/dts/imx6sx-sabreauto.dts > > b/arch/arm/boot/dts/imx6sx-sabreauto.dts > > index 72da5ac..83f7cac 100644 > > --- a/arch/arm/boot/dts/imx6sx-sabreauto.dts > > +++ b/arch/arm/boot/dts/imx6sx-sabreauto.dts > > @@ -18,6 +18,14 @@ > > reg = <0x80000000 0x80000000>; > > }; > > > > + clocks { > > + codec_osc: anaclk2 { > > + #clock-cells = <0>; > > + compatible = "fixed-clock"; > > + clock-frequency = <24576000>; > > + }; > > + }; > > The clocks container should be removed and the clock node could be put > directly > into the root node. > > Also, I do not see 'codec_osc' being used in this dts. This clock will be used by cs42888 codec, this patch is only to add basic clock source to complete the clock tree. Thanks. Anson.
