On Thursday 31 May 2007 10:32:42 am Yinghai Lu wrote: > On 5/31/07, Bjorn Helgaas <[EMAIL PROTECTED]> wrote: > > On Wednesday 30 May 2007 10:48:59 pm Andrew Morton wrote: > > > You could require that the architecture implement some specific function > > > for mapping the early-uart. > > > > We could, but we already have bt_ioremap, dmi_ioremap, and early_ioremap. > > Do we really want to proliferate more flavors of "early ioremap"? I'd > > rather consolidate the ones we already have. > > > not really.
I'm sorry, I don't understand the point you're making. Andrew's proposal was that we could add early_uart_ioremap to the list of bt_ioremap and dmi_ioremap. I'm suggesting that maybe we should make bt_ioremap smart enough that we could use it for early uart mapping. And maybe we could get rid of dmi_ioremap, and make DMI use bt_ioremap as well (this would require some shims for x86_64 and ia64). > dhcp-umpk12-63-201:/home/yhlu/xx/xx/kernel/linux-2.6/include # grep > bt_ioremap * -r > asm-i386/dmi.h:#define dmi_ioremap bt_ioremap > asm-i386/io.h: * bt_ioremap() and bt_iounmap() are for temporary early > boot-time > asm-i386/io.h:extern void *bt_ioremap(unsigned long offset, unsigned long > size); > asm-i386/io.h:#define dmi_ioremap bt_ioremap > > dhcp-umpk12-63-201:/home/yhlu/xx/xx/kernel/linux-2.6/include # grep > early_ioremap * -r > asm-x86_64/dmi.h:#define dmi_ioremap early_ioremap > asm-x86_64/io.h:extern void *early_ioremap(unsigned long addr, > unsigned long size); > > dhcp-umpk12-63-201:/home/yhlu/xx/xx/kernel/linux-2.6/include # grep > dmi_ioremap * -r > asm-i386/dmi.h:#define dmi_ioremap bt_ioremap > asm-i386/io.h:#define dmi_ioremap bt_ioremap > asm-ia64/io.h:#define dmi_ioremap ioremap > asm-x86_64/dmi.h:extern void *dmi_ioremap(unsigned long addr, unsigned > long size); > asm-x86_64/dmi.h:#define dmi_ioremap early_ioremap - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/