Re: [PATCH v8 02/42] clk: davinci: New driver for davinci PLL clocks

[Stephen Boyd]

Quoting David Lechner (2018-03-15 19:52:18)
> +
> +static int davinci_pll_debug_init(struct clk_hw *hw, struct dentry *dentry)
> +{
> +       struct davinci_pll_clk *pll = to_davinci_pll_clk(hw);
> +       struct debugfs_regset32 *regset;
> +       struct dentry *d;
> +
> +       regset = kzalloc(sizeof(regset), GFP_KERNEL);

Should be sizeof(*regset)?

I squashed this in:

diff --git a/drivers/clk/davinci/pll.c b/drivers/clk/davinci/pll.c
index 588a48927436..89d30bf95102 100644
--- a/drivers/clk/davinci/pll.c
+++ b/drivers/clk/davinci/pll.c
@@ -882,7 +882,7 @@ static int davinci_pll_debug_init(struct clk_hw *hw, struct 
dentry *dentry)
        struct debugfs_regset32 *regset;
        struct dentry *d;
 
-       regset = kzalloc(sizeof(regset), GFP_KERNEL);
+       regset = kzalloc(sizeof(*regset), GFP_KERNEL);
        if (!regset)
                return -ENOMEM;