On Tue, Mar 20, 2018 at 07:29:51PM +1100, NeilBrown wrote: > > ralink_halt() does nothing that machine_halt() > doesn't already do, so it adds no value. > > It actually causes incorrect behaviour due to the > "unreachable()" at the end. This tell the compiler that the > end of the function will never be reached, which isn't true. > The compiler responds by not adding a 'return' instruction, > so control simply moves on to whatever bytes come afterwards > in memory. In my tested, that was the ralink_restart() > function. This means that an attempt to 'halt' the machine > would actually cause a reboot. > > So remove ralink_halt() so that a 'halt' really does halt. > > Signed-off-by: NeilBrown <[email protected]>
Thanks, I've cosmetically tweaked the commit message (mainly reflow to
72 characters) and added:
Fixes: c06e836ada59 ("MIPS: ralink: adds reset code")
Cc: <[email protected]> # 3.9+
and applied for 4.16.
BTW, I'm intrigued to know if there's a particular reason you don't
author / sign-off as "Neil Brown"? Its supposed to be real names, though
"NeilBrown" is hardly difficult to figure out so I don't actually
object.
Cheers
James
signature.asc
Description: Digital signature
