Hi Alexandre, On jeu., mars 22 2018, Alexandre Belloni <[email protected]> wrote:
> Bits have to be cleared in DEVCPU_GCB:GPIO:GPIO_OE for input and set for > output. ocelot_gpio_set_direction() got it wrong and this went unnoticed > when the driver was reworked. > > Reported-by: Gregory Clement <[email protected]> > Signed-off-by: Alexandre Belloni <[email protected]> Acked-by: Gregory CLEMENT <[email protected]> Thanks, Gregory > --- > drivers/pinctrl/pinctrl-ocelot.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/pinctrl-ocelot.c > b/drivers/pinctrl/pinctrl-ocelot.c > index a9423238471e..b5b3547fdcb2 100644 > --- a/drivers/pinctrl/pinctrl-ocelot.c > +++ b/drivers/pinctrl/pinctrl-ocelot.c > @@ -252,7 +252,7 @@ static int ocelot_gpio_set_direction(struct pinctrl_dev > *pctldev, > struct ocelot_pinctrl *info = pinctrl_dev_get_drvdata(pctldev); > > regmap_update_bits(info->map, OCELOT_GPIO_OE, BIT(pin), > - input ? BIT(pin) : 0); > + input ? 0 : BIT(pin)); > > return 0; > } > -- > 2.16.2 > -- Gregory Clement, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering http://bootlin.com
