On 03/28/2018 12:27 AM, Geert Uytterhoeven wrote:
Hi Laura,
On Sat, Mar 10, 2018 at 1:10 AM, Laura Abbott <[email protected]> wrote:
The new challenge is to remove VLAs from the kernel
(see https://lkml.org/lkml/2018/3/7/621)
This patch replaces a VLA with an appropriate call to kmalloc_array.
Signed-off-by: Laura Abbott <[email protected]>
Thanks for your patch!
--- a/drivers/gpio/gpio-xra1403.c
+++ b/drivers/gpio/gpio-xra1403.c
@@ -126,11 +126,16 @@ static void xra1403_dbg_show(struct seq_file *s, struct
gpio_chip *chip)
{
int reg;
struct xra1403 *xra = gpiochip_get_data(chip);
- int value[xra1403_regmap_cfg.max_register];
Apparently xra1403_regmap_cfg.max_register is always 0x15?
What about adding
#define XRA_LAST 15
at the top, and replacing both "XRA_IFR | 0x01" and
xra1403_regmap_cfg.max_register by XRA_LAST instead?
That would avoid doing yet another memory allocation over and over.
Gr{oetje,eeting}s,
Geert
I'm okay with making the change but I think Linus already picked
up the patch into his gpio trees. Linus, do you want a patch on
top of your -devel branch or should I just send a new patch?
Thanks,
Laura
