On Wed, Mar 28, 2018 at 12:03:39PM -0700, Florian Fainelli wrote: > From: Russell King <rmk+ker...@armlinux.org.uk> > > Provide a pointer to the SFP bus in struct net_device, so that the > ethtool module EEPROM methods can access the SFP directly, rather > than needing every user to provide a hook for it. > > Signed-off-by: Russell King <rmk+ker...@armlinux.org.uk> > --- > drivers/net/ethernet/marvell/mvneta.c | 18 ------------------ > drivers/net/phy/phylink.c | 28 ---------------------------- > drivers/net/phy/sfp-bus.c | 6 ++---- > include/linux/netdevice.h | 3 +++ > include/linux/phylink.h | 3 --- > net/core/ethtool.c | 7 +++++++ > 6 files changed, 12 insertions(+), 53 deletions(-)
The diffstats look good, DSA and all other uses of phylink will make a similar saving in code. The new member in the netdev structure is well away from members which are commented as being cache line sensitive. Reviewed-by: Andrew Lunn <and...@lunn.ch> Andrew