Re: [PATCH 06/12] wireless: Convert simple uses of a static const Ethernet broadcast address

[Joe Perches]

On Sat, 2018-03-31 at 14:01 +0000, Pkshih wrote:
> On Sat, 2018-03-31 at 00:05 -0700, Joe Perches wrote:
> > Use the new ether_broadcast_addr global instead to save some object code.
[]
> > diff --git a/drivers/net/wireless/realtek/rtlwifi/core.c
[]
> > @@ -1649,7 +1648,7 @@ static int rtl_op_set_key(struct ieee80211_hw *hw, 
> > enum set_key_cmd cmd,
> >                     memcpy(rtlpriv->sec.key_buf[key_idx],
> >                            key->key, key->keylen);
> >                     rtlpriv->sec.key_len[key_idx] = key->keylen;
> > -                   memcpy(mac_addr, bcast_addr, ETH_ALEN);
> > +                   memcpy(mac_addr, ether_broadcast_addr, ETH_ALEN);
> 
> Use ether_addr_copy(mac_addr, ether_broadcast_addr) ?

This should use eth_broadcast_addr(mac_addr) instead.

There are similar conversion still possible in the tree.
One day.