Hi, > -----Original Message----- > From: Alexey Khoroshilov [mailto:[email protected]] > Sent: vendredi 30 mars 2018 21:55 > To: Mark Brown <[email protected]>; Amelie DELAUNAY > <[email protected]>; Maxime Coquelin > <[email protected]>; Alexandre TORGUE > <[email protected]> > Cc: Alexey Khoroshilov <[email protected]>; [email protected]; > [email protected]; [email protected]; ldv- > [email protected] > Subject: [PATCH] spi: stm32: Fix error handling in stm32_spi_probe() > > clk_get_rate() is below clk_prepare_enable(), so its error should lead to goto > err_clk_disable, not to err_master_put. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov <[email protected]> > --- > drivers/spi/spi-stm32.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/spi/spi-stm32.c b/drivers/spi/spi-stm32.c index > ba9743fa2326..ad1e55d3d5d5 100644 > --- a/drivers/spi/spi-stm32.c > +++ b/drivers/spi/spi-stm32.c > @@ -1129,7 +1129,7 @@ static int stm32_spi_probe(struct platform_device > *pdev) > if (!spi->clk_rate) { > dev_err(&pdev->dev, "clk rate = 0\n"); > ret = -EINVAL; > - goto err_master_put; > + goto err_clk_disable; > } > > spi->rst = devm_reset_control_get_exclusive(&pdev->dev, NULL); > -- > 2.7.4
Thanks for the patch! Reviewed-by: Amelie Delaunay <[email protected]> Regards, Amelie
