On Thu, Apr 5, 2018 at 12:38 AM, Russell King - ARM Linux <[email protected]> wrote: > On Wed, Apr 04, 2018 at 03:34:06PM -0700, Kees Cook wrote: >> On Wed, Apr 4, 2018 at 5:30 AM, Arnd Bergmann <[email protected]> wrote: >> > gcc complains about fortify_panic() possibly returning: >> > >> > arch/arm/boot/compressed/misc.c: In function 'fortify_panic': >> > arch/arm/boot/compressed/misc.c:167:1: error: 'noreturn' function does >> > return [-Werror] >> > >> > This annotates the error() function as __noreturn, which lets gcc >> > see in all configurations that it fortify_panic() cannot return either. >> > >> > Fixes: ee333554fed5 ("ARM: 8749/1: Kconfig: Add ARCH_HAS_FORTIFY_SOURCE") >> > Signed-off-by: Arnd Bergmann <[email protected]> >> >> Acked-by: Kees Cook <[email protected]> > > I'd actually prefer a more robust solution to this - error() is used > in different files, each with their own separate prototype, which is > error-prone. The same goes for a few other variables. The following > is IMHO a more complete (and thus larger) patch:
Right, much better. Acked-by: Arnd Bergmann <[email protected]> I assume you'll just fold it into the original patch if you can, or apply it on top yourself.
