From: Daniel Hung-yu Wu <[email protected]> Reboot or shutdown during delayed works could corrupt communication with EC and certain I2C controller may not be able to recover from the error state.
This patch registers a shutdown callback used to cancel the debugfs log worker thread. Signed-off-by: Daniel Hung-yu Wu <[email protected]> Signed-off-by: Enric Balletbo i Serra <[email protected]> Reviewed-by: Andy Shevchenko <[email protected]> Acked-by: Lee Jones <[email protected]> --- Changes in v5: None Changes in v4: - [6/8] Add Acked-by Lee Jones. Changes in v3: - [6/8] Add the Reviewed-by Andy Shevchenko. Changes in v2: - [6/8] This patch is new in this series. drivers/mfd/cros_ec_dev.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c index 535ffa3cf497..8f51b115f478 100644 --- a/drivers/mfd/cros_ec_dev.c +++ b/drivers/mfd/cros_ec_dev.c @@ -543,6 +543,14 @@ static int ec_device_remove(struct platform_device *pdev) return 0; } +static void ec_device_shutdown(struct platform_device *pdev) +{ + struct cros_ec_dev *ec = dev_get_drvdata(&pdev->dev); + + /* Be sure to clear up debugfs delayed works */ + cros_ec_debugfs_remove(ec); +} + static const struct platform_device_id cros_ec_id[] = { { DRV_NAME, 0 }, { /* sentinel */ }, @@ -585,6 +593,7 @@ static struct platform_driver cros_ec_dev_driver = { }, .probe = ec_device_probe, .remove = ec_device_remove, + .shutdown = ec_device_shutdown, }; static int __init cros_ec_dev_init(void) -- 2.16.3
