On 6.04.2018 11:13, David Howells wrote: > Al Viro <v...@zeniv.linux.org.uk> wrote: > >> lookup_one_len() seriously depends upon exclusive lock > > In the code it says: > > WARN_ON_ONCE(!inode_is_locked(base->d_inode)); > > which checks i_rwsem, but in the banner comment it says: > > * The caller must hold base->i_mutex. > > is one of these wrong?
Before the switch to i_rwsem, inodes had only i_mutex, so in fact the comment is likely stale. > > David >
