On (04/06/18 18:00), Joe Perches wrote:
[..]
> This finds the current two bad uses in addition to
> the existing similar message for string concatenation
> without a space char between concatenated fragments.
>
> For example:
>
> WARNING: break quoted strings at a space character
> #3550: FILE: drivers/scsi/megaraid/megaraid_sas_base.c:3550:
> + dev_notice(&instance->pdev->dev, "moving
> cmd[%d]:%p:%d:%p"
> + "on the defer queue as internal\n",
>
> WARNING: vsprintf %p<extension> string concatenation
> #3550: FILE: drivers/scsi/megaraid/megaraid_sas_base.c:3550:
> + dev_notice(&instance->pdev->dev, "moving
> cmd[%d]:%p:%d:%p"
> + "on the defer queue as internal\n",
>
> I think the new message is not that useful really as the
> existing warning is probably enough.
Oh, so we already have it... Didn't know that. Yes, I think the existing
one is good enough. Thanks for the pointers.
-ss
