On 9 April 2018 at 09:53, Viresh Kumar <[email protected]> wrote: > On 22-03-18, 11:18, Ulf Hansson wrote: >> On 22 March 2018 at 10:59, Viresh Kumar <[email protected]> wrote: >> > On 22-03-18, 10:30, Ulf Hansson wrote: >> >> On 22 December 2017 at 08:26, Viresh Kumar <[email protected]> >> >> wrote: > >> >> > + ret = device_add(&genpd->dev); >> >> >> >> What's the point of adding the device? Can we skip this step, as I >> >> guess the opp core is only using the device as cookie rather actual >> >> using it? No? >> > >> > We also use it for the OPP debugfs stuff, so that would be required I >> > believe. >> >> Right, however, isn't that only using the dev_name(dev), which you >> don't need to add the device to make use of. >> >> Or maybe I missing something around this... > > So I tested this bit. The code works fine even if the device isn't added > (registered), but this looks a bit sloppy to attempt. > > Please let me know what would you prefer in this case, add the device or not.
Well, I don't know if there is policy of how to do this in general. Or perhaps this can be considered as a special case as the device is only going to be used as cookie (at least so far). I suggest we keep it as simple as possible and *not* add (register) the device. Kind regards Uffe
