On Fri, Apr 6, 2018 at 4:16 PM Stephen Boyd <[email protected]> wrote:

> Quoting Lina Iyer (2018-04-06 08:13:56)
> > From: Mahesh Sivasubramanian <[email protected]>
> >
> > Command DB provides information on shared resources like clocks,
> > regulators etc., probed at boot by the remote subsytem and made
> > available in shared memory.
> >
> > Cc: [email protected]
> > Signed-off-by: Mahesh Sivasubramanian <[email protected]>
> > Signed-off-by: Lina Iyer <[email protected]>
> > Reviewed-by: Bjorn Andersson <[email protected]>
> > ---
> >

> Reviewed-by: Stephen Boyd <[email protected]>

> > +       reserved-memory {
> > +               [...]
> > +               qcom,cmd-db@85fe0000 {

> Nitpick: This may want to be called 'memory@85fe0000' because we prefer
> generic node names.

Another nit: the cmd-db region seems to need "no-map" to make the example
actually work.

Reviewed-by: Evan Green <[email protected]>

-Evan

Reply via email to