W dniu 2018-04-11 00:24, Greg Kroah-Hartman napisał(a):
4.15-stable review patch. If anyone has any objections, please let me
know.
------------------
From: Cong Wang <xiyou.wangc...@gmail.com>
[ Upstream commit f12c643209db0626f2f54780d86bb93bfa7a9c2d ]
When we delete a u32 key via u32_delete_key(), we forget to
call idr_remove() to remove its handle from IDR.
Fixes: e7614370d6f0 ("net_sched: use idr to allocate u32 filter
handles")
Reported-by: Marcin Kabiesz <ad...@hostcenter.eu>
Tested-by: Marcin Kabiesz <ad...@hostcenter.eu>
Signed-off-by: Cong Wang <xiyou.wangc...@gmail.com>
Signed-off-by: David S. Miller <da...@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>
---
net/sched/cls_u32.c | 1 +
1 file changed, 1 insertion(+)
--- a/net/sched/cls_u32.c
+++ b/net/sched/cls_u32.c
@@ -478,6 +478,7 @@ static int u32_delete_key(struct tcf_pro
RCU_INIT_POINTER(*kp, key->next);
tcf_unbind_filter(tp, &key->res);
+ idr_remove(&ht->handle_idr, key->handle);
tcf_exts_get_net(&key->exts);
call_rcu(&key->rcu, u32_delete_key_freepf_rcu);
return 0;
Hello,
Thank you for the correction. If you had a problem or was not sure,
please speak. I will try to test new changes or give relevant
information on how to best test this. I have experience in this because
I am currently working on the configuration of routers and in this cut
QoS band.
Thank you again for making the correction. :)
Best Regards
Marcin Kabiesz
