On 04/11/2018 05:43 PM, Andrew F. Davis wrote: > On 04/11/2018 09:15 AM, Peter Rosin wrote: >> This is a current sense amplifier from Analog Devices. >> >> Signed-off-by: Peter Rosin <p...@axentia.se> >> --- >> drivers/iio/afe/Kconfig | 3 +- >> drivers/iio/afe/iio-unit-converter.c | 54 >> ++++++++++++++++++++++++++++++++++++ >> 2 files changed, 56 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/iio/afe/Kconfig b/drivers/iio/afe/Kconfig >> index 642ce4eb12a6..0e10fe8f459a 100644 >> --- a/drivers/iio/afe/Kconfig >> +++ b/drivers/iio/afe/Kconfig >> @@ -10,7 +10,8 @@ config IIO_UNIT_CONVERTER >> depends on OF || COMPILE_TEST >> help >> Say yes here to build support for the IIO unit converter >> - that handles voltage dividers and current sense shunts. >> + that handles voltage dividers, current sense shunts and >> + the LT6106 Current Sense Amplifier from Analog Devices. > > Could work better to split these out into separate drivers. Maybe a > iio-shunt-resistor.c that does just voltage->current with the > appropriate scaling. Then make a a separate lt6106.c.
I don't think we need a separate driver here. There are tons of circuits that all work the same way and all require the same properties. If we'd add a driver for each of them we'd get buried in boilerplate code.
