On Tue, 17 Apr 2018 15:05:33 +0800 Chengguang Xu <cgxu...@gmx.com> wrote:

> When specifying nls option multiple times in a mount,
> current option parsing will cause inaccurate refcount of nls
> module. Hence, call unload_nls for previous one in this case.
> 
> --- a/fs/hfsplus/options.c
> +++ b/fs/hfsplus/options.c
> @@ -171,8 +171,10 @@ int hfsplus_parse_options(char *input, struct 
> hfsplus_sb_info *sbi)
>                               return 0;
>                       }
>                       p = match_strdup(&args[0]);
> -                     if (p)
> +                     if (p) {
> +                             unload_nls(sbi->nls);
>                               sbi->nls = load_nls(p);
> +                     }
>                       if (!sbi->nls) {
>                               pr_err("unable to load nls mapping \"%s\"\n",
>                                      p);

Same problem as in [patch 1/2]

Reply via email to