4.16-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Hans de Goede <[email protected]>

commit e09070c51b280567695022237e57c428e548b355 upstream.

Add irq_polarity module option for easier troubleshooting of irq-polarity
issues.

Cc: [email protected]
Signed-off-by: Hans de Goede <[email protected]>
Signed-off-by: Marcel Holtmann <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>

---
 drivers/bluetooth/hci_bcm.c |   20 +++++++++++++++-----
 1 file changed, 15 insertions(+), 5 deletions(-)

--- a/drivers/bluetooth/hci_bcm.c
+++ b/drivers/bluetooth/hci_bcm.c
@@ -126,6 +126,10 @@ struct bcm_data {
 static DEFINE_MUTEX(bcm_device_lock);
 static LIST_HEAD(bcm_device_list);
 
+static int irq_polarity = -1;
+module_param(irq_polarity, int, 0444);
+MODULE_PARM_DESC(irq_polarity, "IRQ polarity 0: active-high 1: active-low");
+
 static inline void host_set_baudrate(struct hci_uart *hu, unsigned int speed)
 {
        if (hu->serdev)
@@ -975,11 +979,17 @@ static int bcm_acpi_probe(struct bcm_dev
        }
        acpi_dev_free_resource_list(&resources);
 
-       dmi_id = dmi_first_match(bcm_active_low_irq_dmi_table);
-       if (dmi_id) {
-               dev_warn(dev->dev, "%s: Overwriting IRQ polarity to active low",
-                           dmi_id->ident);
-               dev->irq_active_low = true;
+       if (irq_polarity != -1) {
+               dev->irq_active_low = irq_polarity;
+               dev_warn(dev->dev, "Overwriting IRQ polarity to active %s by 
module-param\n",
+                        dev->irq_active_low ? "low" : "high");
+       } else {
+               dmi_id = dmi_first_match(bcm_active_low_irq_dmi_table);
+               if (dmi_id) {
+                       dev_warn(dev->dev, "%s: Overwriting IRQ polarity to 
active low",
+                                dmi_id->ident);
+                       dev->irq_active_low = true;
+               }
        }
 
        return 0;


Reply via email to